fix: Grafana monitoring page iframe embedding and dynamic cluster configuration #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
szedan-rh
force-pushed
the
fix_monitoring
branch
2 times, most recently
from
43539bb to
52bfd58
Compare
…figuration Fixes multiple Grafana integration issues in the dashboard: 405 login errors, localhost redirects, iframe reload loops, and hardcoded cluster URLs. Changes: - dashboard/backend/router/router.go: Enhanced login routing to detect Grafana requests via Content-Type/Referer headers - dashboard/frontend/src/pages/MonitoringPage.tsx: Removed two-step load causing redirect loops, direct dashboard loading via goto endpoint - deploy/openshift/observability/grafana/deployment.yaml: Added proper server config with dynamic route URL placeholder - deploy/openshift/deploy-to-openshift.sh: Dynamic route URL substitution for cluster-agnostic deployments Signed-off-by: Senan Zedan <szedan@redhat.com>
szedan-rh
force-pushed
the
fix_monitoring
branch
from
52bfd58 to
405b8cf
Compare
Collaborator
|
@JaredforReal @Xunzhuo PTAL |
Collaborator
|
@rootfs will work on it! |
Contributor
Author
|
Thank you @JaredforReal |
Collaborator
|
/lgtm |
JaredforReal
approved these changes
Nov 17, 2025
Collaborator
|
@szedan-rh Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiple Grafana integration issues in the dashboard: 405 login errors, localhost redirects, iframe reload loops, and hardcoded cluster URLs.
Changes
Testing