[Perf] Optimize memory peak during EAGLE model loading. #24585
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
mergify
bot
added
deepseek
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes memory usage during model loading by using generators (map) instead of materializing full weight dictionaries in memory. This is a good improvement that reduces peak memory consumption. The changes in vllm/model_executor/models/deepseek_eagle.py and vllm/model_executor/models/llama_eagle.py are correct. However, there is a critical issue in vllm/model_executor/models/llama4_eagle.py where a returned tuple is not unpacked, which will lead to a runtime error. I've added a specific comment with a suggested fix for this.
candyzone
force-pushed
the
dev
branch
2 times, most recently
from
ec9edfa to
736b4a3
Compare
mgoin
changed the title
Signed-off-by: Chen Ding <candy.dc@alibaba-inc.com>
github-actions
bot
added
the
ready
…#24585) Signed-off-by: Chen Ding <candy.dc@alibaba-inc.com>
…#24585) Signed-off-by: Chen Ding <candy.dc@alibaba-inc.com>
…#24585) Signed-off-by: Chen Ding <candy.dc@alibaba-inc.com>
…#24585) Signed-off-by: Chen Ding <candy.dc@alibaba-inc.com> Signed-off-by: charlifu <charlifu@amd.com>
issue #21160
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.