[V0 Deprecation] Remove MultiModalPlaceholderMap
#25366
Merged
+2
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
requested review from
mgoin,
tlrmchlsmth,
WoosukKwon,
yewentao256 and
robertgshaw2-redhat
as code owners
DarkLight1337
added
the
ready
DarkLight1337
requested review from
njhill,
ywang96,
comaniac,
alexm-redhat,
NickLucche,
zhuohan123,
youkaichao and
LucasWilkinson
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the MultiModalPlaceholderMap class and its usages, which were part of the deprecated V0 model runner. The changes are straightforward deletions of code across various files, including tests, attention backends, and multimodal utility modules. The cleanup is well-executed and improves the maintainability of the codebase by removing obsolete components. The changes are consistent and correct.
Isotr0py
approved these changes
Sep 22, 2025
ywang96
approved these changes
Sep 22, 2025
kzawora-intel
added a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Sep 22, 2025
Culprit commit : vllm-project/vllm#25332 and vllm-project/vllm#25321 and vllm-project/vllm#25366 --------- Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Signed-off-by: Konrad Zawora <kzawora@habana.ai> Co-authored-by: Konrad Zawora <kzawora@habana.ai>
slokesha
pushed a commit
to slokesha/vllm-gaudi
that referenced
this pull request
Sep 24, 2025
Culprit commit : vllm-project/vllm#25332 and vllm-project/vllm#25321 and vllm-project/vllm#25366 --------- Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Signed-off-by: Konrad Zawora <kzawora@habana.ai> Co-authored-by: Konrad Zawora <kzawora@habana.ai> Signed-off-by: slokesha <slokeshappa@habana.ai>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Now that V0 model runner is gone, we can remove this.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.