-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[V0 Deprecation] Remove V0 core #25321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the V0 core of vLLM, which is a significant and positive step towards simplifying the codebase. The changes are extensive, touching CI configurations, tests, and core source files, and they consistently reflect the goal of deprecating V0. The majority of the changes involve removing V0-specific code paths, tests, and dependencies. I've identified one critical issue in a CI configuration file that could cause a pipeline failure and should be addressed.
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Culprit commit : vllm-project/vllm#25332 and vllm-project/vllm#25321 and vllm-project/vllm#25366 --------- Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Signed-off-by: Konrad Zawora <kzawora@habana.ai> Co-authored-by: Konrad Zawora <kzawora@habana.ai>
Culprit commit : vllm-project/vllm#25332 and vllm-project/vllm#25321 and vllm-project/vllm#25366 --------- Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Signed-off-by: Konrad Zawora <kzawora@habana.ai> Co-authored-by: Konrad Zawora <kzawora@habana.ai> Signed-off-by: slokesha <slokeshappa@habana.ai>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai> Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai> Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai> Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: yewentao256 <zhyanwentao@126.com>
No description provided.