Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 25, 2025

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot added the qwen Related to Qwen models label Sep 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a video profiling issue in Qwen3-VL by reusing Qwen2-VL's profiling logic with some modifications. The changes involve reducing _MAX_FRAMES_PER_VIDEO in qwen2_vl.py and adding a hack in qwen3_vl.py to disable resizing during dummy input generation.

While the hack in qwen3_vl.py is clearly documented as a temporary measure, modifying a constant in qwen2_vl.py to fix an issue in qwen3_vl.py introduces an undesirable side effect on Qwen2-VL's own profiling. My review includes a suggestion to isolate this change to qwen3_vl.py to avoid impacting other models.

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 25, 2025
@Isotr0py Isotr0py merged commit 17b4c66 into vllm-project:main Sep 25, 2025
61 checks passed
@Isotr0py Isotr0py deleted the fix-qwen3-do-resize branch September 25, 2025 10:36
Zhuul pushed a commit to Zhuul/vllm that referenced this pull request Sep 26, 2025
…iling (vllm-project#25648)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
…iling (#25648)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants