-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[Docs] Have mergify leave a comment with the docs preview link #26412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Have mergify leave a comment with the docs preview link #26412
Conversation
This will make contributors more likely to check it. Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
I've reviewed your pull request. The primary change to add a documentation preview link via Mergify is a great idea to improve the contribution workflow. I've found one potential issue with the implementation that would lead to a broken link. Please see my detailed comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Mergify says the config will be used for the next PR |
…project#26412) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…project#26412) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…project#26412) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
…project#26412) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…project#26412) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…project#26412) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…project#26412) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This will make contributors more likely to check it.