-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
Add @noooop to codeowner for pooling models #26652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds @noooop as a codeowner for pooling models. While this is a great initiative, the current list of owned files is incomplete. I've suggested adding several other files and directories related to pooling to ensure comprehensive ownership and that all relevant changes are reviewed by the designated owner.
Signed-off-by: wang.yuqi <noooop@126.com>
ee71611 to
9dd1578
Compare
Signed-off-by: wang.yuqi <noooop@126.com>
604ab6f to
5f1a358
Compare
Isotr0py
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations!
|
Congratulations, well deserved! |
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: 1994 <1994@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Purpose
Thanks @youkaichao for inviting me to join as a Reviewer for pooling models.
I am excited to contribute further to the vLLM project and am happy to take on the responsibility of reviewing and maintaining the codebase.
I also deeply appreciate the helpful code reviews and guidance from @DarkLight1337 @Isotr0py @maxdebayser @jeejeelee @youkaichao @comaniac @rkooo567
I still remember one year ago when I awkwardly fixed #7874, that was my first time submitting a pull request on gitbub, as well as encountering flaky tests. LOL
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.