Skip to content

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Oct 12, 2025

Purpose

Thanks @youkaichao for inviting me to join as a Reviewer for pooling models.

I am excited to contribute further to the vLLM project and am happy to take on the responsibility of reviewing and maintaining the codebase.

I also deeply appreciate the helpful code reviews and guidance from @DarkLight1337 @Isotr0py @maxdebayser @jeejeelee @youkaichao @comaniac @rkooo567

I still remember one year ago when I awkwardly fixed #7874, that was my first time submitting a pull request on gitbub, as well as encountering flaky tests. LOL


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Oct 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds @noooop as a codeowner for pooling models. While this is a great initiative, the current list of owned files is incomplete. I've suggested adding several other files and directories related to pooling to ensure comprehensive ownership and that all relevant changes are reviewed by the designated owner.

Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!

@youkaichao youkaichao merged commit 4ca2040 into vllm-project:main Oct 12, 2025
5 checks passed
@noooop noooop deleted the noooop-codeowner branch October 12, 2025 06:18
@maxdebayser
Copy link
Contributor

Congratulations, well deserved!

1994 pushed a commit to 1994/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: 1994 <1994@users.noreply.github.com>
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: wang.yuqi <noooop@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants