-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[Frontend] Add request arrival log #26685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a request arrival log to better track the actual arrival time of requests, which is a valuable addition for monitoring and debugging. The implementation is mostly consistent across the various serving entrypoints. I've pointed out one minor inconsistency in the logging approach that should be addressed to maintain a unified logging strategy.
Signed-off-by: ApsarasX <apsarax@outlook.com>
443e0db to
da8557b
Compare
chaunceyjiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can we use FastAPI middleware to accomplish this?
- Under high concurrency and a large volume of requests, excessive log output may not be a good idea.
- We already have a similar feature in place—why doesn’t it meet your needs? Could you please describe this in more detail?
|
|
@ApsarasX "it's critical to log when the request arrives" ... could you describe why in more detail? What are you doing with this timing information? @chaunceyjiang We could make this a See also #26708 |
Purpose
Currently, logs stating
Received request ......are only output after the request has been encoded by the tokenizer. However, the timing of this log does not reflect the actual arrival time of the request.Therefore, I have added an additional log to record the moment the request arrives.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.