-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[CI] Fix mypy for vllm/executor
#26845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on fixing mypy type checking errors, primarily by moving the vllm/executor
module to a group with stricter checks. The changes involve adding more precise type hints, using assert
statements for type narrowing, and suppressing unavoidable mypy errors in Ray actor code with # type: ignore
. These modifications improve the codebase's type safety and are well-aligned with the goal of resolving CI issues. The changes appear correct and I have no high or critical severity concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This directory is V0 code which will be removed soon anyways, I think there is not much value in fixing mypy here
Given that the work has been done and the tests pass, could we merge anyway? The timeline for removal of all remaining V0 code is uncertain and doing this would allow us to push forward with running mypy directly instead of via our complicated script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK then
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Purpose
Part of the #26533
Test