Skip to content

[Feature] Default ignore_eos True for random dataset #28227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2025
+8 −0
Merged

[Feature] Default ignore_eos True for random dataset #28227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9766e3b
Default `ignore_eos` True when `random_output_len` is set
yewentao256 Nov 6, 2025
7faa898
update
yewentao256 Nov 6, 2025
5108962
Merge branch 'main' into wentao-default-ignore_eos-when-random_output…
yewentao256 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions vllm/benchmarks/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,6 +1359,14 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]:
"'--dataset-path' if required."
)

# when using random datasets, default to ignoring EOS
# so generation runs to the requested length
if (
args.dataset_name in ("random", "random-mm")
and args.backend in OPENAI_COMPATIBLE_BACKENDS
):
args.ignore_eos = True

# Load the dataset.
input_requests = get_samples(args, tokenizer)
goodput_config_dict = check_goodput_args(args)
Expand Down