Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Nov 10, 2025

Purpose

Essentially it should match with any files or paths that contain cuda, cutlass, flashinfer, or trtllm

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin changed the title Add mergify rules for nvidia label [CI] Add mergify rules for nvidia label Nov 10, 2025
@mgoin mgoin added the ci/build label Nov 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Mergify rule to automatically label NVIDIA-related pull requests. The rule is well-structured, but the conditions could be expanded to be more comprehensive. I've suggested adding more keywords related to NVIDIA technologies like flashinfer, trtllm, nvml, and nvlink to both file path and title checks. This will improve the accuracy of the automation.

Comment on lines +158 to +165
- or:
- files~=cuda
- files~=cutlass
- files~=flashinfer
- files~=trtllm
- title~=(?i)NVIDIA
- title~=(?i)CUDA
- title~=(?i)CUTLASS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The conditions for applying the nvidia label are a good start, but could be more comprehensive. To improve the rule's accuracy, I suggest expanding the conditions to include other relevant NVIDIA-related keywords that appear in the codebase.

Specifically:

  • flashinfer and trtllm are included for file paths but are missing from the title match.
  • nvml and nvlink are other NVIDIA technologies used in the project and would be beneficial to include in both file and title matches.

This change will help ensure that more relevant PRs are correctly labeled.

    - or:
      - files~=cuda
      - files~=cutlass
      - files~=flashinfer
      - files~=trtllm
      - files~=nvml
      - files~=nvlink
      - title~=(?i)NVIDIA
      - title~=(?i)CUDA
      - title~=(?i)CUTLASS
      - title~=(?i)flashinfer
      - title~=(?i)trtllm
      - title~=(?i)NVML
      - title~=(?i)NVLink

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 10, 2025
@mgoin mgoin requested a review from pavanimajety November 10, 2025 23:40
@vllm-bot vllm-bot merged commit 2e78150 into vllm-project:main Nov 11, 2025
22 of 23 checks passed
@mgoin mgoin deleted the nvidia-mergify branch November 11, 2025 12:28
@mergify mergify bot added the nvidia label Nov 11, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Nov 13, 2025
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants