-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Compressed Tensors] Add XPU wNa16 support
#29484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yiliu30 <yi4.liu@intel.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for wNa16 compressed tensors on XPU by adding a new IPEXwNa16LinearKernel. The changes are mostly self-contained in a new file and registration of the new kernel. However, I've found a critical issue in the implementation of the new kernel within vllm/model_executor/layers/quantization/kernels/mixed_precision/ipex.py. The input feature size for the underlying IPEX linear layer is calculated incorrectly, which will likely lead to runtime failures or incorrect computations. I have also pointed out a confusing and redundant variable assignment that should be cleaned up. Please see the detailed comments for suggestions on how to fix these issues.
vllm/model_executor/layers/quantization/kernels/mixed_precision/ipex.py
Outdated
Show resolved
Hide resolved
vllm/model_executor/layers/quantization/kernels/mixed_precision/ipex.py
Outdated
Show resolved
Hide resolved
|
@robertgshaw2-redhat @mgoin Please help review. The PR is to support the quantized models with compressed tensor format (e.g., quantized by LLM-C/AutoRound) for Intel GPUs. |
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
|
@mgoin @robertgshaw2-redhat , may you help to take a look? |
Signed-off-by: yiliu30 <yi4.liu@intel.com>
jikunshang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for xpu part.
Purpose
cd vllm python examples/offline_inference/basic/generate.py \ --model Intel/Qwen3-8B-W4A16-G128-AutoRound-LLMC-TEST-ONLY \ --gpu_memory_utilization 0.75 \ --enforce-eagerEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.