Skip to content
This repository was archived by the owner on Mar 27, 2023. It is now read-only.

Conversation

akutz
Copy link
Contributor

@akutz akutz commented Oct 17, 2022

This patch adds support for specifying a VM's mininum hardware version in order to enable more control over a VM's hardware version by the DevOps persona. This also enables upgrading brownfield VMs to a more recent hardware version in order to support features like PVCs and Dynamic Direct Path I/O devices.

@akutz akutz force-pushed the feature/vm-min-hw-version branch 2 times, most recently from 63d38d4 to efe31b8 Compare October 17, 2022 19:11
This patch adds support for specifying a VM's
mininum hardware version in order to enable
more control over a VM's hardware version by
the DevOps persona. This also enables upgrading
brownfield VMs to a more recent hardware version
in order to support features like PVCs and
Dynamic Direct Path I/O devices.
@akutz akutz force-pushed the feature/vm-min-hw-version branch from efe31b8 to 51f0fbc Compare October 17, 2022 19:13
@sreyasn
Copy link
Contributor

sreyasn commented Oct 17, 2022

Change looks good to me. We'll need to decide on what takes precedence when the VM Class Config Spec's hw version and the VM Spec's hw version are set. VM Spec overrides Class?.

@akutz
Copy link
Contributor Author

akutz commented Oct 17, 2022

Change looks good to me. We'll need to decide on what takes precedence when the VM Class Config Spec's hw version and the VM Spec's hw version are set. VM Spec overrides Class?.

I think we already made that decision when we said the hardware from the class replaces the hardware from the OVF

I misread the above point. The VirtualMachineSpec.MinHardwareVersion always has final say, whether the original value is derived from the OVF or eventually VM Class.

Thanks for the approvals -- I'm going to wait to merge this until we have go-ahead for Shruthi to execute on the implementation. We don't want to add the field until we know we can resource the work to make it available in the next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants