This repository was archived by the owner on Mar 27, 2023. It is now read-only.
docs(timeline): timeline component documentation #3755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vmware-clarity ready! Built with commit cc44856 |
hippee-lee
force-pushed
the
docs/1633-timeline-component
branch
from
cd0cbf2 to
6c94289
Compare
Closed
hippee-lee
added a commit
to hippee-lee/clarity
that referenced
this pull request
Aug 29, 2019
closes vmware-archive#3755 Signed-off-by: Matt Hippely <mhippely@vmware.com>
mathisscott
suggested changes
Aug 29, 2019
coryrylan
suggested changes
Aug 29, 2019
Contributor
coryrylan
left a comment
coryrylan
left a comment
There was a problem hiding this comment.
Just blocking on the one issue with the table showing that there is a angular version of the component.
src/website/src/assets/images/documentation/timeline/all-step-descriptions.svg
Outdated
Show resolved
Hide resolved
coryrylan
approved these changes
Aug 29, 2019
mathisscott
approved these changes
Aug 30, 2019
Contributor
Author
|
NOTE: Do not merge this in until after the 2.2.0 release. |
- Adds svg image assets and optimized the sketch output with online comporession tool - Adds Design Guidelines - Adds Demos, code snippits and a full example for vertical and horizontal - Adds dark theme variables and updates timeline scss for theming Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee
force-pushed
the
docs/1633-timeline-component
branch
from
6819804 to
cc44856
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClrTimeline (Static) Component Documentation
Adding Do Not Merge label as reminder that it can't go into master until after v2.2.0 is published on npm with the timeline code.
NOTE - I still need to find a place to callout the missing dark theme.
Signed-off-by: Matt Hippely mhippely@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
n/a
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information