read_only and volumes added for #3061#3110
Closed
wdhif wants to merge 1 commit intogoharbor:masterfrom
wdhif:read_only
Closed
read_only and volumes added for #3061#3110wdhif wants to merge 1 commit intogoharbor:masterfrom wdhif:read_only
wdhif wants to merge 1 commit intogoharbor:masterfrom
wdhif:read_only
Conversation
- read_only and volumes (in Dockerfiles) for harbor - read_only and volumes (in Compose file) for notary - read_only and volumes (in Dockerfiles) for clair
4 tasks
Contributor
|
@wdhif thanks for the contribution, but per discussion we want to disable the "read_only" by default, and we will refine the docker files such that the containers will work when user enable this flag in docker-compose template. |
Contributor
|
closing as the requirement is addressed in other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add read_only flag for the images of Harbor, as described in #3061
The images will need to be rebuild and push with the new volumes, or the compose will fail.