healthcheck added for #3061#3123
Closed
wdhif wants to merge 1 commit intogoharbor:masterfrom
wdhif:healthcheck
Closed
healthcheck added for #3061#3123wdhif wants to merge 1 commit intogoharbor:masterfrom wdhif:healthcheck
wdhif wants to merge 1 commit intogoharbor:masterfrom
wdhif:healthcheck
Conversation
- vmware/registry - vmware/nginx-photon - vmware/harbor-adminserver - vmware/harbor-ui - vmware/harbor-jobservice
reasonerjt
requested review from
reasonerjt
and removed request for
wy65701436
Contributor
Author
|
We maybe want to wait for #2492 |
4 tasks
reasonerjt
reviewed
Oct 17, 2017
|
|
||
| ENV PORT 5000 | ||
| EXPOSE 5000 | ||
| HEALTHCHECK CMD curl http://localhost:$PORT/v2 || exit 1 |
Contributor
There was a problem hiding this comment.
I think you don' t need the env "PORT", just use 5000 instead.
Contributor
|
Closing this PR as the requirement has been addressed in other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Healthcheck added as described in #3061 for :
It might be better to wait for harbor-db (since it's a mysql image it doesn't have curl) and harbor-log use rsyslog, which is UDP so I cant't use curl.