Helm Chart + bootstrap installation script for Harbor

[nuzz]

A bootstrap script + Helm Chart to install a fully functioning Harbor registry on a Kubernetes cluster. This chart is intended to be provider agnostic. This installation has been tested on AWS (self managed k8s cluster), Google GKE, and Micorsoft AKS.

See README.md for more information

[vmwclabot]

@nuzz, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[coveralls]

Coverage increased (+0.3%) to 60.174% when pulling a4d2e8f on nuzz:feature/helm_chart into 5456c0b on vmware:master.

[reasonerjt]

Thanks for the PR!
We're going to review this but please bear with the delay as there are other focus.

[xeor]

Can we get a NodePort alternative as well? Maybe something like https://github.com/kubernetes/charts/blob/master/stable/postgresql/templates/svc.yaml?

[xeor]

Need to have storageClassName configurable. Defining that in annotations is being deprecated

[xeor]

configurable log-level?

[xeor]

Looking forward for this PR :) But can you also implement:

• Configurable storageclassnames
• Configurable namespace ({{ .Release.Namespace }})
• Don't rely on people having LoadBalancer available..
• I'm not sure rbac is in scope.. But a nice project to generate rbac is https://github.com/liggitt/audit2rbac..
• Same with https://github.com/kubernetes/charts/blob/master/stable/postgresql/templates/networkpolicy.yaml

Some might be for a v2 :)

[paulczar]

@nuzz I've also been working on helm charts for harbor, it looks like we've done fairly similar stuff but we've each made a bit more progress in different ways - https://github.com/paulczar/helm-harbor.

[paulczar]

I'm not a big fan of the bootstrap scripts, I'd rather see defaults that make it work out of the box for minikube installations and documentation on what to change for different install environments.

I'm also not a huge fan of the seperate secrets file loading into a common namespace, I'd rather see the secrets stick to being part of the same namespace as the harbor install. I would also rather keep the secrets as values set in helm ( I know helm doesn't fully support proper secrets, but its coming real soon helm/helm#2721 ).

[reasonerjt]

Two overall comments:

1. I think we should use ingress instead of introducing nginx container in helm chart.
2. Echoing paulczar, I don't think we want a bootstrap script. We should just provide default values in the yaml and provide the reference on how to modify/generate them. For deployment we should rely on helm to generate all necessary artifacts.

[paulczar]

I've been working with the upstream helm charts team with my own harbor charts here - helm/charts#3383

[jessehu]

Hello guys, I'm Jesse Hu from Harbor dev team, will in charge of making Harbor Helm Chart as a formal community feature into harbor github repo. Thanks very much to @paulczar @nuzz @xeor for sharing your harbor chart code, and the PR helm/charts#3383 for adding incubator/harbor chart.
I think the patch by @paulczar https://github.com/paulczar/helm-harbor is a good start, so could you @paulczar please send a formal pull request :)
The bootstrap script in @nuzz is also a good idea which is used to generate random password and SSL certificates. And I think we can consider using the chart template function to implement the bootstrap script https://masterminds.github.io/sprig/crypto.html, then it's a part of the harbor chart, not a standalone script outside harbor chart.
Any thought? :)

[jessehu]

@paulczar I have a fork to make your code work with latest Harbor 1.4.0 release jessehu/helm-harbor@c2818c7

[vmwclabot]

@nuzz, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

[jessehu]

We have merged #4271

[reasonerjt]

Thanks, @paulczar, @jessehu and @nuzz
I'm closing this PR.

[jessehu]

Hi @nuzz @xeor and other guys interested in Harbor Helm Chart, we have merged #4373 'Update Harbor helm chart to deploy Harbor 1.4.0 release' into harbor master branch https://github.com/vmware/harbor/tree/master/contrib/helm/harbor.

Welcome to try it out and your continuous idea and code contribution to Harbor are still appreciated. Thanks!