feat: inject callbacks to code handler (VF-182) #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 72.28% 72.28%
=======================================
Files 36 36
Lines 855 855
Branches 147 147
=======================================
Hits 618 618
Misses 216 216
Partials 21 21
Continue to review full report at Codecov.
|
leartgjoni-voiceflow
added
ready for review
and removed
in progress
DecathectZero
left a comment
DecathectZero
left a comment
There was a problem hiding this comment.
overall logic looks good, small comments and feedback
lib/Handlers/setV2.ts
Outdated
| `; | ||
| node.sets.forEach((set) => { | ||
| if (!set.variable) return; | ||
| if (!variables.has(set.variable) || !runtime.variables.has(set.variable)) { |
There was a problem hiding this comment.
this line should only be if (!variables.has(set.variable)) {
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
if and set v2 handlers with eval happening on vm2 through code handler