Skip to content

Conversation

@Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented May 6, 2022

No description provided.

@coveralls
Copy link

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 2282588781

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 19 (68.42%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 77.612%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/voku/PHPStan/Rules/IfConditionBooleanNotRule.php 0 1 0.0%
src/voku/PHPStan/Rules/IfConditionBooleanOrRule.php 0 5 0.0%
Totals Coverage Status
Change from base Build 2282359218: -0.09%
Covered Lines: 104
Relevant Lines: 134

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #8 (3ad9a31) into master (dfaa696) will decrease coverage by 1.30%.
The diff coverage is 70.00%.

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
- Coverage     77.30%   76.00%   -1.31%     
+ Complexity      103       95       -8     
============================================
  Files             7        7              
  Lines           163      150      -13     
============================================
- Hits            126      114      -12     
+ Misses           37       36       -1     
Impacted Files Coverage Δ
...c/voku/PHPStan/Rules/IfConditionBooleanNotRule.php 0.00% <0.00%> (ø)
...rc/voku/PHPStan/Rules/IfConditionBooleanOrRule.php 0.00% <0.00%> (ø)
...c/voku/PHPStan/Rules/IfConditionBooleanAndRule.php 100.00% <100.00%> (ø)
src/voku/PHPStan/Rules/IfConditionHelper.php 93.22% <100.00%> (+2.31%) ⬆️
src/voku/PHPStan/Rules/IfConditionRule.php 100.00% <100.00%> (ø)
...u/PHPStan/Rules/IfConditionTernaryOperatorRule.php 87.50% <100.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfaa696...3ad9a31. Read the comment docs.

@voku
Copy link
Owner

voku commented May 6, 2022

🥇

@voku voku merged commit fc1af5d into voku:master May 6, 2022
@Slamdunk Slamdunk deleted the if_to_all_conditions branch May 6, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants