Skip to content

feat(validation): Support array indexing in JSON path validation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

feat(validation): Support array indexing in JSON path validation #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e85b94
feat(validation): Support array indexing in JSON path validation
elwafa Feb 12, 2025
dbb382d
remove unused code
elwafa Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Extractors/JsonExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,11 @@ public function validate(): bool
if (empty($this->selector) || $this->selector === '$.') {
throw new InvalidJsonPathException('JSON path cannot be empty');
}
// Validate the selector ex: $.meta.token
// Validate the selector ex: $.meta.token or $.data[0].name
// Validate the selector follows proper JSON path format
// Should start with $ followed by dot and valid path segments
if (! preg_match('/^\$(\.[a-zA-Z0-9_]+)*$/', $this->selector)) {
$pattern = '/^\$(\.[a-zA-Z0-9_]+|\[[0-9]+\])*$/';
if (! preg_match($pattern, $this->selector)) {
throw new InvalidJsonPathException('Invalid JSON path');
}

Expand Down
9 changes: 9 additions & 0 deletions tests/Units/JsonExtractorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ public static function validJsonPathProvider(): array
['with_underscore'],
['with.numbers.123'],
['mixed.path_with.numbers123'],
['mixed[0].path'],
['mixed[0].path[1]'],
['mixed[0].path[1].with[2].numbers[3]'],
];
}

Expand All @@ -67,6 +70,12 @@ public static function invalidJsonPathProvider(): array
['$invalid.start'],
['invalid$.middle'],
['path.with.$'],
['$.data[abc]'],
['$.data[0].name[abc]'],
['$.data[0].name[0].'],
['$.data[0].name[0].[1]'],
['$.data[0].name[0].[1].'],
['$.data[0].name[0].[1].name'],
];
}

Expand Down