Bug in MatrixEnumerator

voonfoo · web-flow · commit 31ee4a94e60d · 2021-04-21T16:30:09.000+08:00
Matrix index should be less than (column * row) instead of (column + row)
diff --git a/SharpMath/Geometry/MatrixEnumerator.cs b/SharpMath/Geometry/MatrixEnumerator.cs
@@ -26,7 +26,7 @@ public void Dispose()
         public bool MoveNext()
         {
             _index++;
-            return _index < _matrix.ColumnCount + _matrix.RowCount;
+            return _index < _matrix.ColumnCount * _matrix.RowCount;
         }
 
         public void Reset()
@@ -36,4 +36,4 @@ public void Reset()
 
         public double Current => _matrix[(uint) _index % _matrix.ColumnCount, (uint) _index / _matrix.RowCount];
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public void Dispose()`
`26`	`26`	`public bool MoveNext()`
`27`	`27`	`{`
`28`	`28`	`_index++;`
`29`		`- return _index < _matrix.ColumnCount + _matrix.RowCount;`
	`29`	`+ return _index < _matrix.ColumnCount * _matrix.RowCount;`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`public void Reset()`
`@@ -36,4 +36,4 @@ public void Reset()`
`36`	`36`
`37`	`37`	`public double Current => _matrix[(uint) _index % _matrix.ColumnCount, (uint) _index / _matrix.RowCount];`
`38`	`38`	`}`
`39`		`-}`
	`39`	`+}`