Skip to content

Conversation

@vihanb
Copy link
Member

@vihanb vihanb commented Aug 23, 2017

This adds a series of changes oriented around parser improvements:

  • Command Chains (sayHi to: downgoat)
  • Block Statements (if, for)
  • Fixes positioning data
  • Fixes error reporting with position data
  • Fixes FIX-IT position referencing

I have:

  • Ran a test (npm run dev && npm test)
  • Added tests for my changes
  • Documented my code thoroughly.

vihanb and others added 13 commits June 3, 2017 22:43
This adds basic regenerator tests for expressions. The regenerator
is the thing which takes an AST and is supposed to output a valid
string which should evaluate to the same thing. It can also be
used to inspect the AST to ensure precedence and the actual AST is
correct.

Signed-off-by: Vihan B <contact@vihan.org>
Signed-off-by: Vihan B <contact@vihan.org>
Signed-off-by: Vihan B <contact@vihan.org>
Signed-off-by: somebody1234 <ehern.lee@gmail.com>
Signed-off-by: somebody1234 <ehern.lee@gmail.com>
…n-develop

Signed-off-by: somebody1234 <ehern.lee@gmail.com>
Signed-off-by: vihanb <contact@vihan.org>
Signed-off-by: somebody1234 <ehern.lee@gmail.com>
@codecov
Copy link

codecov bot commented Sep 3, 2017

Codecov Report

Merging #61 into develop will decrease coverage by 6.05%.
The diff coverage is 44.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #61      +/-   ##
===========================================
- Coverage    61.02%   54.96%   -6.06%     
===========================================
  Files           89      101      +12     
  Lines          803      926     +123     
===========================================
+ Hits           490      509      +19     
- Misses         313      417     +104
Impacted Files Coverage Δ
src/vsl/parser/vslscope.js 100% <ø> (ø) ⬆️
src/vsl/parser/nodes/initializerStatement.js 85.71% <ø> (ø)
src/vsl/parser/nodes/classStatement.js 100% <ø> (ø) ⬆️
src/vsl/parser/vsltokentype.js 100% <ø> (ø) ⬆️
src/vsl/parser/nodes/getter.js 0% <0%> (ø)
src/vsl/parser/parserError.js 66.66% <0%> (-33.34%) ⬇️
src/vsl/parser/nodes/setter.js 0% <0%> (ø)
src/vsl/parser/vsldoctokenizer.js 0% <0%> (ø)
src/vsl/parser/nodes/typeAlias.js 0% <0%> (ø)
src/vsl/parser/nodes/typeDeclaration.js 0% <0%> (-83.34%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60394d...7c3dcbe. Read the comment docs.

Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too good but at least it works :P

@vihanb vihanb merged commit 94269fe into develop Sep 7, 2017
@somebody1234 somebody1234 deleted the merge/command-chain-develop branch September 7, 2017 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants