Skip to content

Allow Button to use reakit's composition #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2020
Merged

Allow Button to use reakit's composition #3

merged 3 commits into from
Jul 28, 2020

Conversation

@matheusps
Copy link
Collaborator

@matheusps matheusps commented Jul 28, 2020 •
edited
Loading

What is the purpose of this pull request?

As the title says

What problem is this solving?

We may need the as prop to allow composition.

How should this be manually tested?

Clone the repo and yarn && yarn start

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Quality improvement (tests or refactors)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (small fix or feature that doesn't impact functionalities)
  • Requires change to documentation, which has been updated accordingly

@matheusps matheusps self-assigned this Jul 28, 2020
@matheusps matheusps marked this pull request as ready for review July 28, 2020 12:25
@matheusps matheusps merged commit 1a2f813 into master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasaarcoverde lucasaarcoverde lucasaarcoverde approved these changes

@emersonlaurentino emersonlaurentino Awaiting requested review from emersonlaurentino

Assignees

@matheusps matheusps

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matheusps @lucasaarcoverde