fixes #358 - support "validateBeforeSubmit" with async validators #366
Conversation
…validators * added `validateAsync` (default: false) form option * added `isAsync` parameter to FormGenerator.validate() * FormGenerator.validate() and AbstractField.validate() return Promise when `validateAsync` or `isAsync` is true * renamed `click` handler to `onClick` in FieldSubmit * added `onValidationError(model, schema, errors)` to FieldSubmit schema to handle validation errors * added async validator support for FieldSupport * changed `each` to `forEach` in various places, as "each" is an alias to "forEach" and "forEach" looks more explicit * removed call to Vue.util.hyphenate as this is no longer supported by Vue, replaced with equivalent `String.replace` expression * updated fieldSubmit.spec to add "valid form" and "invalid form" tests, valid forms will always call `onSubmit`, invalid forms will not call `onSubmit` (when validateBeforeSubmit = true) * various code clean up
| validate(calledParent) { | ||
| this.clearValidationErrors(); | ||
| let validateAsync = objGet(this.formOptions, "validateAsync", false); | ||
|
|
There was a problem hiding this comment.
Why need the validateAsync option? Is it not enough if we check the type of result of validator function (Promise or not)?
There was a problem hiding this comment.
The updated code returns a promise if validateAsync is true, and waits for async validation to complete ... this is not what the current code does, so the new option is a way to enable it while maintaining backwards compatibility so we don’t break forms that expect the validate function to return a Boolean.
There was a problem hiding this comment.
V3 would likely remove this option and always return a promise from validate... making it the default validation mode, which is what most people are likely expecting from the current async validation.
There was a problem hiding this comment.
Ok. in v3 we change it to easier (handle all as Promise)
2 participants
fixes #358 - support "validateBeforeSubmit" with async validators
validateAsync(default: false) form optionisAsyncparameter to FormGenerator.validate()validateAsyncorisAsyncis trueclickhandler toonClickin FieldSubmitonValidationError(model, schema, errors)to FieldSubmit schema to handle validation errorseachtoforEachin various places, as "each" is an alias to "forEach" and "forEach" looks more explicitString.replaceexpressiononSubmit, invalid forms will not callonSubmit(when validateBeforeSubmit = true)To use the new async validation logic, just set
validateAsync: truein your form options, or call FormGenerator.validate(true) manually.Code should be backwards compatible. Additional tests are likely needed to test the new async logic.