Skip to content

Conversation

@ik9999
Copy link
Contributor

@ik9999 ik9999 commented Apr 15, 2018

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix
  • What is the current behavior? (You can also link to an open issue here)
    Firefox throws reference error when using fieldUpload and onChange callback
  • What is the new behavior (if this is a feature change)?
    Firefox doesnt throw reference error and user get the event object in onChange callback function
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No
  • Other information:

@zoul0813
Copy link
Member

can you change event to $event - as event is a reserved word in most runtimes.

@ik9999
Copy link
Contributor Author

ik9999 commented Apr 15, 2018

@zoul0813 Done.

@zoul0813 zoul0813 merged commit 6e1d2ef into vue-generators:master Apr 16, 2018
@zoul0813
Copy link
Member

Thanks for the fix @ik9999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants