Skip to content

Conversation

@lionel-bijaoui
Copy link
Member

Very small stuff, should be quickly merge if you agree with the changes

Lionel Bijaoui added 2 commits August 24, 2016 15:30
@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Coverage remained the same at 81.4% when pulling 04a71a0 on lionel-bijaoui:LB_small_fix into dcfde9f on icebob:master.

"pretest": "npm run lint",
"test": "npm run unit",
"ci": "karma start test/unit/karma.conf.js --auto-watch --no-single-run --reporters=dots"
"ci": "karma start test/unit/karma.conf.js --auto-watch --no-single-run --reporters=dots --port=9877"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need it?

Copy link
Member Author

@lionel-bijaoui lionel-bijaoui Aug 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in the commit, It allow to use both npm run test and npm run ci at the same time without warning. It is a very small stuff, but since I use them all the time, I want to avoid any interference even if very unlikely.

@icebob icebob merged commit 750afd4 into vue-generators:master Aug 24, 2016
@icebob
Copy link
Member

icebob commented Aug 24, 2016

ok, merged

@lionel-bijaoui lionel-bijaoui deleted the LB_small_fix branch August 24, 2016 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants