Skip to content

Conversation

@Lukinoh
Copy link
Contributor

@Lukinoh Lukinoh commented Nov 2, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.

Remove typings error in the console when using ant-design-vue in my project.

  1. Resolve what problem.

There is some inconsistancy in the typings of statistic-counted definition file, and that produce the following error during type checking:

ant-design-vue/types/statistic/statistic-countdown"' has no default export.

  1. Related issue link.

Should I create a separate issue ?

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Nov 2, 2019

Deploy preview for ant-desing-vue processing.

Building with commit d25e62e

https://app.netlify.com/sites/ant-desing-vue/deploys/5dbd82b438cbdb0008e9b2f2

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #1375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1375   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files         156      156           
  Lines        5393     5393           
  Branches     1521     1521           
=======================================
  Hits         4740     4740           
  Misses        583      583           
  Partials       70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd1735...d25e62e. Read the comment docs.

@tangjinzhou tangjinzhou merged commit 548f10d into vueComponent:master Nov 4, 2019
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants