Skip to content

Conversation

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 9, 2020

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)
  • Button
  • Grid

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 9, 2020

今天比较忙,做了 2 个。
本地看不到官网,不太好进行调试,所以先进行整个的移植。

待官网可进行演示后,发现具体问题,再进行调试。

@xrkffgg xrkffgg mentioned this pull request Apr 9, 2020
56 tasks
@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 9, 2020

example 调试 太麻烦了,一般只写上一个例子,确保 config 生效。不过我看了一下,antdv 的 样式 基本和 antd 一致,所以直接拿过来 大部分 都适用的。

@xrkffgg xrkffgg changed the title feat: add rtl button\grid feat: add rtl button/grid Apr 9, 2020
@tangjinzhou tangjinzhou merged commit 0da42f0 into vueComponent:feat-rtl Apr 22, 2020
@xrkffgg xrkffgg deleted the add-rtl-buttongrid branch November 22, 2020 14:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants