feat: add rtl menu #2056
Closed
feat: add rtl menu #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I need you update |
Member
Author
|
when you done, i will rebase this branch |
Amour1688
reviewed
Apr 17, 2020
components/menu/MenuItem.jsx
Outdated
| title: title || (level === 1 ? $slots.default : ''), | ||
| }; | ||
| const siderCollapsed = this.layoutSiderContext.sCollapsed; | ||
| const direction = this.configProvider.direction; |
xrkffgg
commented
Apr 17, 2020
components/menu/index.jsx
Outdated
| const { collapsedWidth } = layoutSiderContext; | ||
| const { getPopupContainer: getContextPopupContainer } = this.configProvider; | ||
| const { prefixCls: customizePrefixCls, theme, getPopupContainer } = this.$props; | ||
| const getPrefixCls = this.configProvider.getPrefixCls; |
Member
Author
There was a problem hiding this comment.
@Amour1688 之前有一个 getPrefixCls 这么写了，然后我就统一这样写了😂😂
Member
Author
There was a problem hiding this comment.
如果要用解构，还要改之前的，所以就没动，保持统一。
看以后是不是需要一起改
Member
Author
|
Close first, reopen when necessary. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge
Additional Plan? (Optional if not new feature)