Skip to content

fix(Tabs): dropdown show #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2023
Merged

fix(Tabs): dropdown show #6757

merged 1 commit into from
Aug 6, 2023

Conversation

@CCherry07
Copy link
Member

@CCherry07 CCherry07 commented Jul 18, 2023 •
edited
Loading

@CCherry07 CCherry07 changed the title fix: Dropdown show fix(Tabs): dropdown show Jul 18, 2023
@CCherry07 CCherry07 requested a review from tangjinzhou July 20, 2023 11:11
tangjinzhou
tangjinzhou requested changes Jul 29, 2023
View reviewed changes
components/tabs/src/TabNavList/OperationNode.tsx
onTabClick,
popupClassName,
} = props;
if (!tabs.length) return null;
Copy link
Member

@tangjinzhou tangjinzhou Jul 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moreNode 等于 null 就好了吧

@CCherry07 CCherry07 requested a review from tangjinzhou July 29, 2023 04:51
@tangjinzhou
Copy link
Member

tangjinzhou commented Jul 31, 2023

没改啊 ？

@aibayanyu20 aibayanyu20 mentioned this pull request Jul 31, 2023
Closed
1 task
@CCherry07
Copy link
Member Author

CCherry07 commented Jul 31, 2023

必须把这里所有的dom都要卸载掉，如果只有morenode卸载，下面的AddButton也会显示的

        <div
          class={classNames(`${prefixCls}-nav-operations`, attrs.class)}
          style={attrs.style as CSSProperties}
        >
          {moreNode}
          <AddButton prefixCls={prefixCls} locale={locale} editable={editable} />
        </div>

@wangmin0314
Copy link

wangmin0314 commented Aug 3, 2023

改好了请艾特我一下，谢谢

@tangjinzhou tangjinzhou merged commit 531ae16 into vueComponent:main Aug 6, 2023
@huangfuwenhao
Copy link

huangfuwenhao commented Aug 23, 2023

Tabs 这个 bug 终于修复了，感谢大佬们的辛勤维护，点赞👍

@github-actions
Copy link

github-actions bot commented Aug 23, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tangjinzhou tangjinzhou Awaiting requested review from tangjinzhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CCherry07 @tangjinzhou @wangmin0314 @huangfuwenhao