[DONE] Fix the example text translation and finish join.md #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m074554n
changed the title
3imed-jaberi
changed the title
atefBB
suggested changes
Jan 11, 2020
mohamedsgap
suggested changes
Jan 12, 2020
mohamedsgap
left a comment
mohamedsgap
left a comment
There was a problem hiding this comment.
be aware of the extra spaces before comma.
atefBB
approved these changes
Jan 13, 2020
Aissaoui-Ahmed
approved these changes
Jan 14, 2020
m074554n
commented
Jan 15, 2020
Member
Author
Dear @mohamedsgap Thank you for your reviews. Could you please add the changes as code suggestions so we can commit it directly on Github. Thanks |
Aissaoui-Ahmed
requested changes
Jan 15, 2020
mohamedsgap
approved these changes
Jan 16, 2020
mohamedsgap
left a comment
mohamedsgap
left a comment
There was a problem hiding this comment.
Good job so far, @MohamedHassanWD
Happy hacking and keep contributing 💯 👍
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Co-Authored-By: Aissaoui Ahmed <algarabi05@gmail.com>
Aissaoui-Ahmed
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.