fix(compat): add entities to @vue/compat deps to fix CJS edge cases
#12514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-ssr
@vue/compiler-dom
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Fixes vuejs#10609 Unlike the `vue` package, direct dependencies of `@vue/compat` are not externalized: https://github.com/vuejs/core/blob/201936f9a3909ae9dca4e131e1f5ad5a1c0feb77/rollup.config.js#L274 So it depends on `entities` directly in its CJS build, unlike the `vue` one which indirectly depends on it via `@vue/compiler-core`. So `entities` must be explicitly added to `@vue/compat` deps to avoid incorrect dependency resolution due to different `node_modules` layouts, such as in vuejs#10609 (comment)
haoqunjiang
force-pushed
the
fix-compat-cjs-deps
branch
from
499b298 to
e572a25
Compare
edison1105
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10609
Unlike the
vuepackage, direct dependencies of@vue/compatare not externalized:core/rollup.config.js
Line 274 in 201936f
So it depends on
entitiesdirectly in its CJS build, unlike thevueone which indirectly depends on it via@vue/compiler-core. Soentitiesmust be explicitly added to@vue/compatdeps to avoid incorrect dependency resolution due to differentnode_moduleslayouts, such as in #10609 (comment)