Skip to content

fix(custom-element): prevent defineCustomElement from mutating the options object #13791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

fix(custom-element): prevent defineCustomElement from mutating the options object #13791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
436866d
fix(custom-element): the 2nd argument can unexpectedly mutate the 1st…
LeeSamFong Aug 21, 2025
1be15af
chore: tweaks
edison1105 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/runtime-dom/__tests__/customElement.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,4 +1774,16 @@ describe('defineCustomElement', () => {
`<el-hyphenated-attr-removal></el-hyphenated-attr-removal>`,
)
})

test('no unexpected mutation of the 1st argument', () => {
const Foo = {
name: 'Foo',
}

defineCustomElement(Foo, { shadowRoot: false })

expect(Foo).toEqual({
name: 'Foo',
})
})
})
4 changes: 2 additions & 2 deletions packages/runtime-dom/src/apiCustomElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ export function defineCustomElement(
*/
_createApp?: CreateAppFunction<Element>,
): VueElementConstructor {
const Comp = defineComponent(options, extraOptions) as any
if (isPlainObject(Comp)) extend(Comp, extraOptions)
let Comp = defineComponent(options, extraOptions) as any
if (isPlainObject(Comp)) Comp = extend({}, Comp, extraOptions)
class VueCustomElement extends VueElement {
static def = Comp
constructor(initialProps?: Record<string, any>) {
Expand Down
Loading