Skip to content

fix(hmr): properly stop render effects during hmr re-render #14023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix(hmr): properly stop render effects during hmr re-render #14023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/runtime-vapor/__tests__/components/Teleport.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ describe('renderer: VaporTeleport', () => {
expect(target.innerHTML).toBe('<div>teleported 2</div>')
})

test.todo('parent rerender + toggle disabled', async () => {
test('parent rerender + toggle disabled', async () => {
const target = document.createElement('div')
const root = document.createElement('div')
const parentId = 'test3-parent-rerender'
Expand Down
8 changes: 3 additions & 5 deletions packages/runtime-vapor/src/renderEffect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ export class RenderEffect extends ReactiveEffect {
this.onTrigger = instance.rtg
? e => invokeArrayFns(instance.rtg!, e)
: void 0

// register effect for stopping them during HMR rerender
;(instance.renderEffects || (instance.renderEffects = [])).push(this)
}
job.i = instance
}
Expand Down Expand Up @@ -71,11 +74,6 @@ export class RenderEffect extends ReactiveEffect {
setCurrentInstance(...prev)
if (__DEV__ && instance) {
startMeasure(instance, `renderEffect`)

if (instance.renderEffects) {
instance.renderEffects.forEach(e => e.stop())
instance.renderEffects = []
}
}
}

Expand Down
Loading