Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,21 @@ export function render(_ctx) {
}"
`;

exports[`cache multiple access > dynamic property access with parentheses 1`] = `
"import { setProp as _setProp, renderEffect as _renderEffect, template as _template } from 'vue';
const t0 = _template("<div></div>", true)

export function render(_ctx) {
const n0 = t0()
_renderEffect(() => {
const _foo_bar = _ctx.foo[_ctx.bar]
_setProp(n0, "x", (_foo_bar).x)
_setProp(n0, "bar", (_foo_bar))
})
return n0
}"
`;

exports[`cache multiple access > function calls with arguments 1`] = `
"import { setProp as _setProp, renderEffect as _renderEffect, template as _template } from 'vue';
const t0 = _template("<div></div>")
Expand Down
10 changes: 10 additions & 0 deletions packages/compiler-vapor/__tests__/transforms/vBind.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,16 @@ describe('cache multiple access', () => {
expect(code).contains('_setProp(n0, "id", _obj[1][_ctx.baz] + _obj.bar)')
})

test('dynamic property access with parentheses', () => {
const { code } = compileWithVBind(`
<div :x="(foo[bar]).x" :bar="(foo[bar])"></div>
`)
expect(code).matchSnapshot()
expect(code).contains('const _foo_bar = _ctx.foo[_ctx.bar]')
expect(code).contains('_setProp(n0, "x", (_foo_bar).x)')
expect(code).contains('_setProp(n0, "bar", (_foo_bar))')
})

test('variable name substring edge cases', () => {
const { code } = compileWithVBind(
`<div :id="title + titles + title"></div>`,
Expand Down
4 changes: 3 additions & 1 deletion packages/compiler-vapor/src/generators/expression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,10 @@ function analyzeExpressions(expressions: SimpleExpressionNode[]) {
continue
}

const seenParents = new Set<Node>()
walkIdentifiers(exp.ast, (currentNode, parent, parentStack) => {
if (parent && isMemberExpression(parent)) {
if (parent && isMemberExpression(parent) && !seenParents.has(parent)) {
seenParents.add(parent)
const memberExp = extractMemberExpression(parent, id => {
registerVariable(id.name, exp, true, {
start: id.start!,
Expand Down
Loading