build(api): add bundling to support tree shaking #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I simplified the PR by removing rollup. These changes effectively make the devtools fully tree shakable. I tested it on the router on the branch feat/devtools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a lot but the important part is to make
@vue/devtools-apitree shakable by exporting an ESM version of the library as well as changing some of the enums. But I thought exposing only one version was not really viable, that's why I added rollup to create multiple versions. We can also add common js version.This probably needs some discussion. I kind fell like adding rollup is overkill but maybe it's necessary to be able to use it in different scenarios (bundlers, browsers)