Skip to content

Conversation

@NataliaTepluhina
Copy link
Member

Description of Problem

Currently, both slots and named slots have diagrams to illustrate the explanation. However, the scope slots chapter (which is the "hardest" to understand) lacks the visual explanation

Proposed Solution

A diagram is added for scoped slots

@netlify
Copy link

netlify bot commented Feb 12, 2022

✔️ Deploy Preview for vuejs ready!

🔨 Explore the source changes: 3e56a05

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/620b6de6c12a1b0007e33f51

😎 Browse the preview: https://deploy-preview-1522--vuejs.netlify.app

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking the time to create the diagram. Looks good to me!

@skirtles-code
Copy link
Contributor

I'm wondering about the small differences from the code that comes just before the picture. e.g. The use of #default rather than v-slot and the extra <template> tag. The text just before the example emphasises that the example is showing a single default slot with v-slot, but the code style in the picture is more akin to working with named scoped slots.

@NataliaTepluhina
Copy link
Member Author

@skirtles-code thank you for catching this! I've simplified a diagram to match the code, would you mind taking a second look? 🙏🏻

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skirtles-code skirtles-code merged commit 75a3a72 into main Feb 17, 2022
@skirtles-code skirtles-code deleted the add-scoped-slot-diagram branch February 17, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants