chore: fixing type errors with core members json #1529
Conversation
|
✔️ Deploy Preview for vuejs ready! 🔨 Explore the source changes: 70c5e9e 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/6208d87dfcf02c00072871a3 😎 Browse the preview: https://deploy-preview-1529--vuejs.netlify.app |
| website?: Link | ||
| socials: Socials | ||
| sponsor?: string | ||
| sponsor?: boolean | string |
There was a problem hiding this comment.
From a quick search, it looks like this field is only used in one place, which uses it for a v-if. I think the handful of entries with string values are leftover from an incomplete migration and should just be switched to true instead.
There was a problem hiding this comment.
Isn't there a button for sponsors? 
There was a problem hiding this comment.
Yeah, sorry, that's what I meant. That button in TeamMember.vue seems to be the only place that uses the sponsor property and it just treats it as a boolean. There are 5 people in members-core.json that have a string value for sponsor, but I believe they should all just be switched to true, and then sponsor doesn't need to support the string type.
|
It just doesn't match the real-world data model... we're hardcoding the
GitHub right now, but people have Open Collectives, Ko-fi, etc. There's no
harm in keeping it really.
…On Sun, Feb 13, 2022 at 9:11 PM skirtle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/about/team/Member.ts
<#1529 (comment)>:
> @@ -9,7 +9,8 @@ export interface Member {
languages: string[]
website?: Link
socials: Socials
- sponsor?: string
+ sponsor?: boolean | string
Yeah, sorry, that's what I meant. That button in TeamMember.vue seems to
be the only place that uses the sponsor property and it just treats it as
a boolean. There are 5 people in members-core.json that have a string
value for sponsor, but I believe they should all just be switched to true,
and then sponsor doesn't need to support the string type.
—
Reply to this email directly, view it on GitHub
<#1529 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVL4BASQGFZ2RUBATDTRODU3BQDXANCNFSM5OIVO5UQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
2 participants
Description of Problem
There were some type errors in the
<TeamPage>when mounting the team list. Turns out there was a typo and some type mismatches.I was investigating vuejs/theme#36 and noticed it.