-
-
Notifications
You must be signed in to change notification settings - Fork 698
chore(lint): setup typescript-eslint #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
I think we will never use |
|
The type definitions in our repository appear to be outdated. Just curious — why aren't we directly referencing some of the node types from |
|
Additionally, is the team interested in migrating to a pnpm workspace? I believe this would allow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sets up typescript-eslint linting for TypeScript files in the project. It adds ESLint rules and configurations specifically for .ts and .mts files, enabling strict TypeScript linting across the codebase.
Key changes:
- Added
@typescript-eslint/eslint-plugindependency and configured TypeScript-specific ESLint rules - Updated ESLint configuration to support TypeScript files with appropriate parser and plugin settings
- Applied auto-fixes from the new linting rules across TypeScript files (formatting, string concatenation, error handling)
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added @typescript-eslint/eslint-plugin dependency |
| eslint.config.mjs | Configured TypeScript parser, plugin, and rules for .ts and .mts files; added eslint-typegen.d.ts to ignores |
| typings/eslint-plugin-vue/util-types/ast/es-ast.ts | Fixed type from BigInt (constructor) to bigint (TypeScript primitive type) |
| vitest.config.mts | Auto-formatted by new linting rules (removed semicolons, condensed arrays) |
| docs/.vitepress/vite-plugin.mts | Applied linting auto-fixes (removed unused parameter, renamed error variable, replaced substring with slice, used template literals) |
| docs/.vitepress/theme/index.ts | Flattened nested if statements for better readability |
| docs/.vitepress/config.mts | Converted arrow function return to implicit return; added eslint-disable comment |
| docs/.eslintrc.js | Removed as configuration moved to flat config in root |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I don't know. @ota-meshi can you elaborate? |
FloEdelmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Since the nodes provided by |
ota-meshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.