feat(vscode): support tsdk path for Eclipse Theia #5806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for Eclipse Theia by implementing dynamic TypeScript SDK path resolution. Previously, the extension hardcoded the VS Code TypeScript SDK path, which caused failures in Eclipse Theia environments where TypeScript is located in a different directory structure.
- Introduced a new
resolveTsdkPath()function that checks multiple locations for the TypeScript SDK - Added fallback logic to support Eclipse Theia's TypeScript path (
deps/typescript/lib) - Implemented error handling to notify users when the TypeScript SDK cannot be found
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johnsoncodehk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5741