-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update composing-stores.md #3052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
According to "https://pinia.vuejs.org/core-concepts/#Setup-Stores", it claimed that "you must return all state properties in setup stores for Pinia to pick them up as state." Anyway, this code broke that rule , I believe is a typo, hence I "put" the `list` ref back into the user store.
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughDocumentation change: the cart store example's public return object in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to "https://pinia.vuejs.org/core-concepts/#Setup-Stores", it claimed that "you must return all state properties in setup stores for Pinia to pick them up as state." Anyway, this code broke that rule , I believe is a typo, hence I "put" the
listref back into the user store.Summary by CodeRabbit