Skip to content

Conversation

SergiCL
Copy link

@SergiCL SergiCL commented Apr 17, 2020

Sorry for the delay, I've been a little more busy than expected.

This should be enough to solve #57. However, I would like to spend some more time (this weekend) to add more robust tests and to rethink some parts.

TODO:

  • Don't allow trigger in disabled elements
  • Add all old tests cases (from vue-test-utils)
  • Add more robust tests
  • Drop IE support?


export default function createDOMEvent(
eventString: String,
options: Object = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, you can type this like so:

interface TriggerOptions {
  key: 'enter' | 'keyup' | ...
}

if you aren't sure about TS i can look into this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm not sure I know what you mean. If it's something simple and you want to take care of it yourself that's fine with me, go ahead with it 👍.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some types, I not sure if that's what you meant.

@lmiller1990
Copy link
Member

lmiller1990 commented Apr 18, 2020

This looks great so far! Are there types for dom-event-types? eg yarn add --dev @types/dom-event-types. LMK if/when you want a review.

Take your time - no rush :)

@SergiCL SergiCL marked this pull request as ready for review April 19, 2020 15:25
@SergiCL SergiCL requested a review from lmiller1990 April 19, 2020 15:29
@lmiller1990 lmiller1990 self-assigned this Apr 20, 2020
@lmiller1990
Copy link
Member

This is a very solid PR. I played with it and seems to cover everything - excellent job! I merged in the latest master with beta-2 and everything is passing.

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, good work

@lmiller1990 lmiller1990 merged commit 53859e6 into vuejs:master Apr 21, 2020
@SergiCL
Copy link
Author

SergiCL commented Apr 21, 2020

Thank you very much. You're doing a great job with this library. If I can help you with anything else, let me know.

@SergiCL SergiCL deleted the pr/add-modifiers-to-triggered-event branch April 21, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants