-
Notifications
You must be signed in to change notification settings - Fork 272
feat: add modifiers to trigger function #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add modifiers to trigger function #77
Conversation
src/create-dom-event.ts
Outdated
|
||
export default function createDOMEvent( | ||
eventString: String, | ||
options: Object = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, you can type this like so:
interface TriggerOptions {
key: 'enter' | 'keyup' | ...
}
if you aren't sure about TS i can look into this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm not sure I know what you mean. If it's something simple and you want to take care of it yourself that's fine with me, go ahead with it 👍.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some types, I not sure if that's what you meant.
This looks great so far! Are there types for dom-event-types? eg Take your time - no rush :) |
This is a very solid PR. I played with it and seems to cover everything - excellent job! I merged in the latest master with beta-2 and everything is passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, good work
Thank you very much. You're doing a great job with this library. If I can help you with anything else, let me know. |
Sorry for the delay, I've been a little more busy than expected.
This should be enough to solve #57. However, I would like to spend some more time (this weekend) to add more robust tests and to rethink some parts.
TODO: