Skip to content

Conversation

@NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Dec 21, 2019

What does this PR do?

I've extended an example for createLocalVue API, adding localVue.use call.

Why this is important?

People tend to take examples very literally, copy-pasting them to their codebase without any additions. Results could be really dramatic: I've just found out 120 files of GitLab codebase create localVue instances and inject them via shallowMount for no reason. This PR is trying to show the real need for creating localVue in the test case

@JessicaSachs JessicaSachs merged commit 089a6ca into vuejs:dev Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants