Skip to content

Conversation

@NoiseFan
Copy link
Contributor

@NoiseFan NoiseFan commented Dec 1, 2025

Description

Based on @antfu/eslint-config, the formatting operation is completed when pr is submitted, and the code style is unified.

@cwandev
Copy link
Collaborator

cwandev commented Dec 4, 2025

Thanks for the PR! 😊

I really appreciate your contribution and the idea of adding a formatting CI process. However, after consideration, I don't think we need this right now.

Here's why:

  1. We already have pre-commit hooks configured (simple-git-hooks + lint-staged) that automatically format code before commits, which covers most cases
  2. Auto-committing formatting changes in CI would create extra commits that could clutter PR history
  3. This would be redundant with our existing pre-commit hooks

If we start seeing formatting issues frequently in the future, we could consider adding a check-only CI workflow that fails if formatting is needed, rather than auto-fixing.

Thanks again for your contribution and understanding! 🙏

@cwandev cwandev closed this Dec 4, 2025
@NoiseFan
Copy link
Contributor Author

NoiseFan commented Dec 4, 2025

I understand that this is a back-up measure. Some codes can be modified directly without installing dependencies. If his code style and project are not unified, this time will be even worse.

@cwandev
Copy link
Collaborator

cwandev commented Dec 4, 2025

I understand that this is a back-up measure. Some codes can be modified directly without installing dependencies. If his code style and project are not unified, this time will be even worse.

Thanks for your additional explanation. I understand your concerns, but I still prefer a check-only approach rather than auto-fixing. Thank you for your understanding, and I look forward to your continued participation. 😁

@NoiseFan
Copy link
Contributor Author

NoiseFan commented Dec 4, 2025

Thank you for taking the time to think it over ! Hope he gets better !

@cwandev
Copy link
Collaborator

cwandev commented Dec 4, 2025

Hey @NoiseFan!I've changed my mind. Thanks for your patience and persistence in explaining the use case. I think your approach makes sense as a backup measure. Let me merge this PR.

@cwandev cwandev reopened this Dec 4, 2025
Copy link
Collaborator

@cwandev cwandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @NoiseFan 👍

@cwandev cwandev merged commit f580061 into vuepont:main Dec 4, 2025
4 checks passed
@NoiseFan NoiseFan deleted the ci/autofix branch December 4, 2025 16:14
@NoiseFan
Copy link
Contributor Author

NoiseFan commented Dec 4, 2025

Yes, the merge pull request uses square and merge, so the merge history is clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants