-
Notifications
You must be signed in to change notification settings - Fork 62
ci(autofix): add formatting ci process #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! 😊 I really appreciate your contribution and the idea of adding a formatting CI process. However, after consideration, I don't think we need this right now. Here's why:
If we start seeing formatting issues frequently in the future, we could consider adding a check-only CI workflow that fails if formatting is needed, rather than auto-fixing. Thanks again for your contribution and understanding! 🙏 |
|
I understand that this is a back-up measure. Some codes can be modified directly without installing dependencies. If his code style and project are not unified, this time will be even worse. |
Thanks for your additional explanation. I understand your concerns, but I still prefer a check-only approach rather than auto-fixing. Thank you for your understanding, and I look forward to your continued participation. 😁 |
|
Thank you for taking the time to think it over ! Hope he gets better ! |
|
Hey @NoiseFan!I've changed my mind. Thanks for your patience and persistence in explaining the use case. I think your approach makes sense as a backup measure. Let me merge this PR. |
cwandev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @NoiseFan 👍
|
Yes, the merge pull request uses |
Description
Based on
@antfu/eslint-config, the formatting operation is completed whenpris submitted, and the code style is unified.