Skip to content

Commit 96decf0

Browse files
committed
chore: remove componentChunkName
1 parent 69fb015 commit 96decf0

File tree

5 files changed

+6
-22
lines changed

5 files changed

+6
-22
lines changed

packages/core/src/page/createPage.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,12 @@ export const createPage = async (
8686
})
8787

8888
// resolve page component and extract headers & links
89-
const {
90-
componentFilePath,
91-
componentFilePathRelative,
92-
componentFileChunkName,
93-
} = await resolvePageComponentInfo({
94-
app,
95-
htmlFilePathRelative,
96-
key,
97-
})
89+
const { componentFilePath, componentFilePathRelative } =
90+
await resolvePageComponentInfo({
91+
app,
92+
htmlFilePathRelative,
93+
key,
94+
})
9895

9996
const { chunkFilePath, chunkFilePathRelative, chunkName } =
10097
resolvePageChunkInfo({ app, htmlFilePathRelative, key })
@@ -137,7 +134,6 @@ export const createPage = async (
137134
filePathRelative,
138135
componentFilePath,
139136
componentFilePathRelative,
140-
componentFileChunkName,
141137
chunkFilePath,
142138
chunkFilePathRelative,
143139
chunkName,

packages/core/src/page/resolvePageComponentInfo.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,16 @@ export const resolvePageComponentInfo = async ({
1515
}): Promise<{
1616
componentFilePath: string
1717
componentFilePathRelative: string
18-
componentFileChunkName: string
1918
}> => {
2019
// resolve component file path
2120
const componentFilePathRelative = path.join(
2221
'pages',
2322
`${htmlFilePathRelative}.vue`,
2423
)
2524
const componentFilePath = app.dir.temp(componentFilePathRelative)
26-
const componentFileChunkName = key
2725

2826
return {
2927
componentFilePath,
3028
componentFilePathRelative,
31-
componentFileChunkName,
3229
}
3330
}

packages/core/src/types/page.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,6 @@ export type Page<
113113
*/
114114
componentFilePathRelative: string
115115

116-
/**
117-
* Component file chunk name
118-
*
119-
* Only take effect in webpack
120-
*/
121-
componentFileChunkName: string
122-
123116
/**
124117
* Page file path
125118
*/

packages/core/tests/page/createPage.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ describe('core > page > createPage', () => {
8080
expect(page.componentFilePathRelative).toBe(
8181
`pages/${page.htmlFilePathRelative}.vue`,
8282
)
83-
expect(page.componentFileChunkName).toBe(page.key)
8483
expect(page.chunkFilePath).toBe(
8584
app.dir.temp(`pages/${page.htmlFilePathRelative}.js`),
8685
)

packages/core/tests/page/resolvePageComponentInfo.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ describe('core > page > resolvePageComponentInfo', () => {
1919
expect(resolved).toEqual({
2020
componentFilePath: app.dir.temp('pages/foo.html.vue'),
2121
componentFilePathRelative: 'pages/foo.html.vue',
22-
componentFileChunkName: 'key',
2322
})
2423
})
2524
})

0 commit comments

Comments
 (0)