-
Notifications
You must be signed in to change notification settings - Fork 919
fix(markdown): decode assets link to ensure bundler can find the file #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I just added more test cases, which will fail for now. I think we should make all those cases passed. (You can still modify those test cases as needed) |
|
I don't think alias is needed, as I am not thinking of any situation which a person should define a alia containing chinese. While a markdown folder likely to contain chinese images,(like harmony os official docs), so relative links is necessary. Even if we resolve those alias begin with @, alias are not forced to begin with The only way to fit this is to decode back every link not begin with |
|
I think just decode the original |
meteorlxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some refactor. Thanks for your contribution ❤️
This is an issue in all VuePress versions.
should be allowed. But
markdown-it's default behavior will encode it to./%E4%B8%AD%E5%9B%BD.png, so that bundler won't be able to find the image file.I made a fix in V1 by my
vuepress-plugin-md-enhance, but I think V2 can support it.