This repository was archived by the owner on May 28, 2023. It is now read-only.
Remove default user and password from config/default.json #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated vuestorefront#334 As of 5.0 value not_analyzed is no longer applicable. Reference: https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_mapping_changes.html#_literal_index_literal_property Citation: On all field datatypes (except for the deprecated string field), the index property now only accepts true/false instead of not_analyzed/no. The string field still accepts analyzed/not_analyzed/no. As per https://www.elastic.co/guide/en/elasticsearch/reference/1.4/mapping-core-types.html, not_analyzed means that its still searchable, but does not go through any analysis process or broken down into tokens. As per https://www.elastic.co/guide/en/elasticsearch/reference/current/text.html, index means Should the field be searchable? Accepts true (default) or false. So, changing index value not_analyzed to true. We can also remove index key as default value is true, but as I am unsure how it works when migrating to new release with schema changes. Setting it true as it may cause no harm and produces desired results
Update README.md – Node 10.x is now required
Done: Remove index value not_analyzed for some fields as it is deprecated vuestorefront#334
Typo in README.md
This commit removes the user and password from `config/default.json`. This allows to not set a username and password when connecting to Elasticsearch; Previously the default values were used if username and password were omitted from `config/local.json` Fixes vuestorefront#358 Signed-off-by: Kevin Gimbel <hallo@kevingimbel.com>
andrzejewsky
approved these changes
Nov 6, 2019
Contributor
|
@KevinGimbel thanks for PR, good point! Please change base to |
Contributor
Author
|
@andrzejewsky I've changed the base to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the user and password from
config/default.json.This allows to not set a username and password when connecting to
Elasticsearch; Previously the default values were used if username and
password were omitted from
config/local.jsonFixes #358