Skip to content
This repository was archived by the owner on May 28, 2023. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Dec 18, 2019

Check message property instead of errorMessage in apiError function to return correct error message from API.

@ghost
Copy link
Author

ghost commented Dec 25, 2019

Based on @pkarw suggestion I updated message check for both message and errorMessage properties.
BWT: Function parameter code never gets used, should it be used somehow? Maybe in the same way as message:

const resultCode = errorObj.code ? errorObj.code : (code ? code : 500);

Copy link
Contributor

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good point regarding the code parameter - it should be used as a default value (instead of 500) in the line 88

Thanks!

@pkarw pkarw requested a review from andrzejewsky January 28, 2020 12:18
@andrzejewsky andrzejewsky merged commit 5b82730 into vuestorefront:develop Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants