This repository was archived by the owner on May 28, 2023. It is now read-only.
fetch attributes based on aggregates #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibkigonzo
changed the title
pkarw
reviewed
Jan 30, 2020
pkarw
approved these changes
Jan 30, 2020
pkarw
suggested changes
Jan 30, 2020
Contributor
pkarw
left a comment
pkarw
left a comment
There was a problem hiding this comment.
great job. we need to add support for this feature for the graphql resolvers as well
andrzejewsky
approved these changes
Jan 30, 2020
Contributor
andrzejewsky
left a comment
andrzejewsky
left a comment
There was a problem hiding this comment.
@gibkigonzo this is exactly what I meant! amazing work! 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: vuestorefront/vue-storefront#4001 vuestorefront/mage2vuestorefront#99
Description:
In general this change allow to fetch attributes with needed options
for example:
{'color': [49]}=> will return color attribute with option that has id 49It's used only for products (and response is transformed into attribute_metadata), but we can expose it as endpoint if needed.