Remove every call to the global variable

[DavidRouyer]

Alternatives:

• Event bus
• Local storage
• Root store

Variables:

• global.$VS.version -> root store
• global.$VS.__DEMO_MODE__ -> root store or env.process variable handled by Webpack
• global.$VS.isSSR -> Vue.prototype.$isServer
• global.$VS.storeView -> root store
• global.$VS.localCache -> Vue.prototype
• global.$VS.twoStageCachingDisabled -> root store
• global.$VS.twoStageCachingDelta1 -> root store
• global.$VS.twoStageCachingDelta2 -> root store
• global.$VS.userTokenInvalidateLock -> root store
• global.$VS.config -> root store
• global.$VS.cacheErrorsCount -> property of LocalForageCacheDriver
• global.$VS.db.attributesCollection -> root store
• global.$VS.db.cartsCollection -> root store
• global.$VS.db.categoriesCollection -> root store
• global.$VS.db.cmsData -> root store
• global.$VS.db.checkoutFieldsCollection -> root store
• global.$VS.db.claimsCollection -> root store
• global.$VS.db.compareCollection -> root store
• global.$VS.db.elasticCacheCollection -> root store
• global.$VS.db.newsletterPreferencesCollection -> root store
• global.$VS.db.ordersCollection -> root store
• global.$VS.db.ordersHistoryCollection -> root store
• global.$VS.db.syncTaskCollection -> root store
• global.$VS.db.usersCollection -> root store
• global.$VS.db.wishlistCollection -> root store
• global.$VS.eventBus -> Vue.prototype
• global.$VS.i18n -> Vue.prototype

[pkarw]

Related to #1507

[pkarw]

https://github.com/inversify/InversifyJS - and some kind of global Registries?

Let's say we'll be having a singleton registries named like:

• Database - for collections
• Context - for SSR, storeView, localCache, eventBus, i18n
• Config - for config

Then we can in the first step refactor /core/store/lib/i18n to just use this kind of registry that we'll be resolved by IoC to get the specific properties.

I mean - it's kind of first step easier and faster than refactoring every single instance of the objects to IoC property

[DavidRouyer]

It looks like the stores can communicate with the root store, so we don't need inversify, everything should be in the root store!

[DavidRouyer]

I suggest to remove those first 11 global variables and replace it with what I'm suggesting for each one (I can do it with a little refactoring), what do you guys think @pkarw @Igloczek @filrak?

[pkarw]

I think that we should start with some incremental changes - the first 11 variables to be moved to root store : for me it’s fine, fair enough

@Igloczek, @filrak?

[Igloczek]

Moving this to the root store makes sense for me, but probably will be worth to clean up the store/index.js file or at least add some comments here, since it's kinda hard to understand what is going on, because it doesn't look like the typical Vuex store setup.

[pkarw]

@DavidRouyer I belive this one is good close; could You close it?